JPDev@programming.dev to Programmer Humor@programming.dev · 2 years agoReview Pleaseprogramming.devimagemessage-square126linkfedilinkarrow-up1997
arrow-up1997imageReview Pleaseprogramming.devJPDev@programming.dev to Programmer Humor@programming.dev · 2 years agomessage-square126linkfedilink
minus-squareJesus_666@feddit.delinkfedilinkarrow-up26·2 years agoOr, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps. If that’s not how you worked on the change than you either rewrite the history to make it look like you did or you’ll have to start over.
minus-squareBrianTheeBiscuiteer@lemmy.worldlinkfedilinkarrow-up2·2 years agoVery good point. We often do one PR per story so people tend to think that’s a limit.
Or, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps.
If that’s not how you worked on the change than you either rewrite the history to make it look like you did or you’ll have to start over.
Very good point. We often do one PR per story so people tend to think that’s a limit.