I remember when I was working with .NET and I saw some web service code and I saw there was no try catches. They didn’t have a global catch in the asax either or anything. I just wrapped each call into a try catch and log.
I got the same treatment where my manager wanted to know what happened with the increase in errors. I told him what I did. My manager got another developer to go through my commits regardless. I was a bit upset at the lack of trust.
A manager that can’t read a simple try catch commit? Why am I surprised.
deleted by creator
I joined a team years ago where everyone would catch exceptions then throw a different exception in the catch, swallowing the original. Sometimes these were nested many layers. Troubleshooting was a nightmare.
I spent a week deleting all of them and told everybody that “try” was now a forbidden word outside of entry points.
deleted by creator
The second panel would be “No, I enabled error reporting. Those errors belong to just you.”
“My project” doesn’t exist in any team. It’s everyone’s project. A manager needs to have a long conversation with Pink Pants.
If you build your project at anything but highest error level,
clang -Wall
etc., you’re letting errors in, relying at best on coincidence to work the way you think it does.Commit it and don’t revert it!
Source: https://www.commitstrip.com/2015/04/27/the-eye-opener-commit/
Also on twitter:
- Twitter @CommitStrip
- Nitter link
- Nitter RSS Feed: https://nitter.cz/CommitStrip/rss
I would normally put an if-statement before that to verify if IGNORANCE still equals BLISS
That’s why PHP team gave us null coalescing (??), oh the misery we went through writing if / else
Isn’t it how most frameworks do it by default? As in, crashing on E_NOTICE?